He was learning/had been learning French for ten years when he moved to France.

[Marika33]

Are both of these sentences correct or only one? If both, what's the difference in meaning between them (if any)?

• He was learning French for ten years when he moved to France. (the past continuous + duration + when + the past simple)
• He'd been learning French for ten years when he moved to France. (the past perfect continuous + duration + when + the past simple)

 

[5jj]

The first activity ended when he moved. #1 is therefore incorrect.
#2 is fine.

 

[Marika33]

#1 is therefore incorrect.
#2 is fine.

Thanks! If I change "when" to "before", what's the answer now?

Are both of these sentences correct or only one? If both, what's the difference in meaning between them (if any)?

• He was learning French for ten years before he moved to France. (the past continuous + duration + before + the past simple)
• He'd been learning French for ten years before he moved to France. (the past perfect continuous + duration + before + the past simple)

 

[5jj]

The first doesn't really work. The past simple is better.
The second is possible. I think when is more natural than before.